This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
fix flaky EWMA test #205
Merged
fix flaky EWMA test #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
commented
Aug 10, 2022
| mu := exp | ||
| sig := 10.0 | ||
| next := func() time.Duration { | ||
| mu := (rand.NormFloat64() * sig) + mu |
There was a problem hiding this comment.
This was the problem. This would generate values outside of the range [90, 110] due to float overflows.
marten-seemann
commented
Aug 10, 2022
|
|
||
| for i := 0; i < 10; i++ { | ||
| time.Sleep(200 * time.Millisecond) |
There was a problem hiding this comment.
Totally useless sleep making this test run for 2s.
marten-seemann
force-pushed
the
fix-flaky-ewma-test
branch
from
740652d
to
963d385
Compare
MarcoPolo
approved these changes
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203.